Skip to content

Clone kafka 18894 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Clone kafka 18894 #40

wants to merge 12 commits into from

Conversation

@DDShantanuBadmanji
Copy link

Delete this text and replace it with a detailed description of your change. The
PR title and body will become the squashed commit message.

If you would like to tag individuals, add some commentary, upload images, or
include other supplemental information that should not be part of the eventual
commit message, please use a separate comment.

If applicable, please include a summary of the testing strategy (including
rationale) for the proposed change. Unit and/or integration tests are expected
for any behavior change and system tests should be considered for larger
changes.

@coderabbitai
Copy link

coderabbitai bot commented Oct 1, 2025

Warning

Rate limit exceeded

@DDShantanuBadmanji has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 54 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between ed79212 and 5989a26.

📒 Files selected for processing (13)
  • Vagrantfile (1 hunks)
  • clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java (4 hunks)
  • clients/src/main/java/org/apache/kafka/common/config/ConfigTransformer.java (3 hunks)
  • clients/src/main/java/org/apache/kafka/common/config/provider/ConfigProvider.java (1 hunks)
  • clients/src/test/java/org/apache/kafka/common/config/ConfigTransformerTest.java (5 hunks)
  • clients/src/test/java/org/apache/kafka/common/config/provider/MonitorableConfigProvider.java (1 hunks)
  • connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java (2 hunks)
  • connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java (1 hunks)
  • connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfigTransformer.java (3 hunks)
  • connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java (3 hunks)
  • connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTransformerTest.java (5 hunks)
  • connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java (5 hunks)
  • connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/PluginsTest.java (4 hunks)
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch clone-KAFKA-18894

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@refacto-test
Copy link

refacto-test bot commented Oct 1, 2025

Refacto is reviewing this PR. Please wait for the review comments to be posted.

@gemini-code-assist
Copy link

Summary of Changes

Hello @DDShantanuBadmanji, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant architectural enhancement by integrating Kafka's ConfigProvider mechanism with its internal Plugin framework. The primary goal is to enable ConfigProvider implementations to expose metrics, thereby improving their observability and manageability. This involves a widespread refactoring to wrap ConfigProvider instances in a Plugin object, updating all relevant components to interact with these new wrappers, and ensuring proper metric registration and resource cleanup.

Highlights

  • Metric Support for Config Providers: ConfigProvider implementations can now implement the Monitorable interface to register metrics, enhancing observability within the Kafka ecosystem. This allows for better monitoring of custom configuration providers.
  • Plugin Wrapper for Config Providers: ConfigProvider instances are now consistently wrapped in a Plugin object. This wrapper facilitates standardized metric registration and lifecycle management across various components that utilize ConfigProviders.
  • Refactoring of Config Provider Instantiation and Usage: The internal handling and instantiation of ConfigProviders have been updated across AbstractConfig, ConfigTransformer, MirrorMakerConfig, Worker, and WorkerConfigTransformer to leverage the new Plugin wrapper. This includes changes to method signatures, variable types, and how providers are accessed and closed.
  • Enhanced Test Coverage: New test cases and modifications to existing tests have been added to ensure the correct functioning of the Plugin wrapping and metric registration for ConfigProviders, including verifying that metrics are properly tagged and that the withPluginMetrics method is called at the appropriate time.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 1, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a thoughtful refactoring to wrap ConfigProvider instances within a generic Plugin class. This change enables better lifecycle management and, importantly, adds support for metrics for ConfigProviders that implement the Monitorable interface. The modifications are consistently applied across the codebase, including AbstractConfig, ConfigTransformer, and the Connect runtime. The new functionality is well-supported by new tests, such as testMonitorableConfigProvider in WorkerTest, which validates the metrics integration. The overall implementation is clean, improves the plugin architecture, and I have no further suggestions for improvement.

@DDShantanuBadmanji
Copy link
Author

/refacto-test

@refacto-test
Copy link

refacto-test bot commented Oct 1, 2025

Refacto is reviewing this PR. Please wait for the review comments to be posted.

@DDShantanuBadmanji
Copy link
Author

/refacto-test

@refacto-test
Copy link

refacto-test bot commented Oct 1, 2025

Refacto is reviewing this PR. Please wait for the review comments to be posted.

@DDShantanuBadmanji
Copy link
Author

/refacto-test

@refacto-test
Copy link

refacto-test bot commented Oct 1, 2025

Refacto is reviewing this PR. Please wait for the review comments to be posted.

@DDShantanuBadmanji
Copy link
Author

DDShantanuBadmanji commented Oct 3, 2025 •
edited
Loading

/refacto-test

@refacto-test
Copy link

refacto-test bot commented Oct 3, 2025

Refacto is reviewing this PR. Please wait for the review comments to be posted.

@DDShantanuBadmanji
Copy link
Author

/refacto-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

clients connect mirror-maker-2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DDShantanuBadmanji @Yunyung